[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in p
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak |
Date: |
Tue, 14 Aug 2018 14:56:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 14/08/2018 14:06, Peter Maydell wrote:
> On 14 August 2018 at 12:52, Paolo Bonzini <address@hidden> wrote:
>> On 14/08/2018 13:40, Juan Quintela wrote:
>>>> CONFIG_SERIAL is a dependency of both CONFIG_SERIAL and
>>>> CONFIG_SERIAL_PCI.
>>>
>>> I guess you here mean CONFIG_SERIAL_ISA or CONFIG_SERIAL_PCI. That is
>>> not enough. CONFIG_SERIAL really means CONFIG_SERIAL_COMMON, and things
>>> like riscv* require it
>>
>> Right, I would put
>>
>> CONFIG_SERIAL=y
>> CONFIG_SERIAL_ISA=y
>>
>> in superio.mak and
>>
>> CONFIG_SERIAL=y
>> CONFIG_SERIAL_PCI=y
>>
>> in pci.mak.
>
> What about the boards that use the serial.c code but do not
> have PCI, ISA or a superio chip? That is, all the boards/devices
> that call serial_mm_init() directly to create a memory-mapped
> 16550.
They just add
CONFIG_SERIAL=y
to the .mak file.
Paolo
- [Qemu-devel] [RFC PATCH v2 00/22] More patches to disable stuff, Juan Quintela, 2018/08/08
- [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Juan Quintela, 2018/08/08
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Thomas Huth, 2018/08/08
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Paolo Bonzini, 2018/08/10
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Juan Quintela, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Paolo Bonzini, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Peter Maydell, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Peter Maydell, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Paolo Bonzini, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Juan Quintela, 2018/08/14
[Qemu-devel] [PATCH v2 03/22] check: Use land/lor when possible, Juan Quintela, 2018/08/08
[Qemu-devel] [PATCH v2 04/22] check: Only test isa-testdev when it is compiled in, Juan Quintela, 2018/08/08