[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename gene
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues |
Date: |
Thu, 16 Aug 2018 08:02:13 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Max Reitz <address@hidden> writes:
> On 2018-08-15 05:43, address@hidden wrote:
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
>
> [...]
>
>> === OUTPUT BEGIN ===
>> Checking PATCH 1/31: block: Use bdrv_refresh_filename() to pull...
>> Checking PATCH 2/31: block: Use children list in bdrv_refresh_filename...
>> Checking PATCH 3/31: block: Skip implicit nodes for filename info...
>> Checking PATCH 4/31: block: Add BDS.auto_backing_file...
>> Checking PATCH 5/31: block: Respect backing bs in bdrv_refresh_filename...
>> ERROR: return is not a function, parentheses are not required
>> #46: FILE: block.c:5192:
>> + return (bs->auto_backing_file[0] != '\0');
>>
>> total: 1 errors, 0 warnings, 136 lines checked
>
> Sure, but I'd hate you personally if you omitted them.
@@
expression E;
@@
- return (E);
+ return E;
You're welcome!
- [Qemu-devel] [PATCH for-3.1 v10 25/31] block: Do not copy exact_filename from format file, (continued)
- [Qemu-devel] [PATCH for-3.1 v10 25/31] block: Do not copy exact_filename from format file, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH for-3.1 v10 24/31] block: Purify .bdrv_refresh_filename(), Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH for-3.1 v10 26/31] block/nvme: Fix bdrv_refresh_filename(), Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH for-3.1 v10 29/31] block/null: Generate filename even with latency-ns, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH for-3.1 v10 27/31] block/curl: Harmonize option defaults, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH for-3.1 v10 30/31] block: BDS options may lack the "driver" option, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH for-3.1 v10 28/31] block/curl: Implement bdrv_refresh_filename(), Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH for-3.1 v10 31/31] iotests: Test json:{} filenames of internal BDSs, Max Reitz, 2018/08/09
- Re: [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues, no-reply, 2018/08/16