Re: [Qemu-devel] [PATCH 44/56] json: Fix latent parser aborts at end of input

[Eric Blake]

On 08/08/2018 07:03 AM, Markus Armbruster wrote:
> json-parser.c carefully reports end of input like this:
>
>      token = parser_context_pop_token(ctxt);
>      if (token == NULL) {
>         parse_error(ctxt, NULL, "premature EOI");
>         goto out;
>      }

Are the TABs in the commit message intentional?

> Except parser_context_pop_token() can't return null, it fails its
> assertion instead.  Same for parser_context_peek_token().  Broken in
> commit 65c0f1e9558, and faithfully preserved in commit 95385fe9ace.
> Only a latent bug, because the streamer throws away any input that
> could trigger it.
>
> Drop the assertions, so we can fix the streamer in the next commit.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   qobject/json-parser.c | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org