[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 28/84] target/mips: Add emulation of some com
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v9 28/84] target/mips: Add emulation of some common nanoMIPS 32-bit instructions |
Date: |
Thu, 16 Aug 2018 09:11:35 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/16/2018 07:57 AM, Aleksandar Markovic wrote:
> + imm = extract32(ctx->opcode, 0, 16);
> + if (rs != 0) {
> + tcg_gen_addi_tl(cpu_gpr[rt], cpu_gpr[rs], imm);
> + tcg_gen_ext32s_tl(cpu_gpr[rt], cpu_gpr[rt]);
> + } else {
> + tcg_gen_movi_tl(cpu_gpr[rt], imm);
> + }
The nanomips pseudocode says ADDIU always sign-extends from 32-bit.
I'm hoping for the sake of nanomips64 that the legacy "inputs to 32-bit
instructions must always be sign-extended" rule has gone?
> + } else if (rt == 0 && shift == 5) {
> + /* PAUSE */
> + if (ctx->hflags & MIPS_HFLAG_BMASK) {
> + generate_exception_end(ctx, EXCP_RI);
> + }
No delay slots for nanomips, so no BMASK.
Probably best to comment that we're implementing PAUSE as a nop.
r~
- [Qemu-devel] [PATCH v9 07/84] target/mips: Add CP0 BadInstrX register, (continued)
- [Qemu-devel] [PATCH v9 07/84] target/mips: Add CP0 BadInstrX register, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 10/84] target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 09/84] target/mips: Don't update BadVAddr register in Debug Mode, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 12/84] elf: Add ELF flags for MIPS machine variants, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 01/84] MAINTAINERS: Update target/mips maintainer's email addresses, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 08/84] target/mips: Implement CP0 Config1.WR bit functionality, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 21/84] target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 02/84] target/mips: Avoid case statements formulated by ranges - part 1, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 28/84] target/mips: Add emulation of some common nanoMIPS 32-bit instructions, Aleksandar Markovic, 2018/08/16
- Re: [Qemu-devel] [PATCH v9 28/84] target/mips: Add emulation of some common nanoMIPS 32-bit instructions,
Richard Henderson <=
- [Qemu-devel] [PATCH v9 17/84] target/mips: Add nanoMIPS base instruction set opcodes, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 14/84] linux-user: Add preprocessor availability control to some syscalls, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 22/84] target/mips: Add emulation of nanoMIPS 16-bit branch instructions, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 04/84] target/mips: Mark switch fallthroughs with interpretable comments, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 03/84] target/mips: Avoid case statements formulated by ranges - part 2, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 15/84] qemu-doc: Amend MIPS-related items, Aleksandar Markovic, 2018/08/16