[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 39/84] target/mips: Add emulation of nanoMIPS
From: |
Aleksandar Markovic |
Subject: |
Re: [Qemu-devel] [PATCH v9 39/84] target/mips: Add emulation of nanoMIPS 32-bit branch instructions |
Date: |
Thu, 16 Aug 2018 16:55:58 +0000 |
> From: Richard Henderson <address@hidden>
> Sent: Thursday, August 16, 2018 6:31 PM
>
> Subject: Re: [PATCH v9 39/84] target/mips: Add emulation of nanoMIPS 32-bit
> branch instructions
>
> On 08/16/2018 07:57 AM, Aleksandar Markovic wrote:
> > + } else {
> > + /* Conditional compact branch */
> > + TCGLabel *fs = gen_new_label();
> > + save_cpu_state(ctx, 0);
>
> I will note that save_cpu_state(ctx, 0) is concerned about updating the BMASK
> bits for branch delay slots, which nanomips does not have. The function could
> probably usefully be renamed so that's clearer.
>
This and other similar cases will be fixed in v10. Perhaps even the naming of
save_cpu_state().
>
> > case NM_P_J:
> > + switch (extract32(ctx->opcode, 12, 4)) {
> > + case NM_JALRC:
> > + case NM_JALRC_HB:
> > + gen_compute_branch(ctx, OPC_JALR, 4, rs, rt, 0, 0);
> > + break;
>
> All of these branches need to be using the new functions that you just added.
> There are even more incorrect uses to follow.
>
All occurrences will be fixed in v10.
- [Qemu-devel] [PATCH v9 51/84] target/mips: Adjust exception_resume_pc() for nanoMIPS, (continued)
- [Qemu-devel] [PATCH v9 51/84] target/mips: Adjust exception_resume_pc() for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 30/84] target/mips: Add emulation of nanoMIPS 48-bit instructions, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 27/84] target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 18/84] target/mips: Add nanoMIPS DSP ASE opcodes, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 34/84] target/mips: Add emulation of misc nanoMIPS instructions (p_lsx), Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 33/84] target/mips: Add emulation of misc nanoMIPS instructions (pool32axf), Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 36/84] target/mips: Implement emulation of nanoMIPS EXTW instruction, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 39/84] target/mips: Add emulation of nanoMIPS 32-bit branch instructions, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 44/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 3, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 42/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 1, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 46/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 5, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 41/84] target/mips: Implement MT ASE support for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 43/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 2, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 29/84] target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV, Aleksandar Markovic, 2018/08/16