[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH PULL 06/15] hw/rdma: Delete useless structure RdmaRm
From: |
Marcel Apfelbaum |
Subject: |
[Qemu-devel] [PATCH PULL 06/15] hw/rdma: Delete useless structure RdmaRmUserMR |
Date: |
Sun, 19 Aug 2018 23:22:51 +0300 |
From: Yuval Shaia <address@hidden>
The structure RdmaRmUserMR has no benefits, remove it an move all its
fields to struct RdmaRmMR.
Reviewed-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Yuval Shaia <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>
---
hw/rdma/rdma_backend.c | 3 +--
hw/rdma/rdma_rm.c | 16 ++++++++--------
hw/rdma/rdma_rm_defs.h | 10 +++-------
3 files changed, 12 insertions(+), 17 deletions(-)
diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
index 647e16399f..52981d652d 100644
--- a/hw/rdma/rdma_backend.c
+++ b/hw/rdma/rdma_backend.c
@@ -271,8 +271,7 @@ static int build_host_sge_array(RdmaDeviceResources
*rdma_dev_res,
return VENDOR_ERR_INVLKEY | ssge[ssge_idx].lkey;
}
- dsge->addr = (uintptr_t)mr->user_mr.host_virt + ssge[ssge_idx].addr -
- mr->user_mr.guest_start;
+ dsge->addr = (uintptr_t)mr->virt + ssge[ssge_idx].addr - mr->start;
dsge->length = ssge[ssge_idx].length;
dsge->lkey = rdma_backend_mr_lkey(&mr->backend_mr);
diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c
index 415da15efe..7403d24674 100644
--- a/hw/rdma/rdma_rm.c
+++ b/hw/rdma/rdma_rm.c
@@ -165,15 +165,15 @@ int rdma_rm_alloc_mr(RdmaDeviceResources *dev_res,
uint32_t pd_handle,
length = TARGET_PAGE_SIZE;
addr = g_malloc(length);
} else {
- mr->user_mr.host_virt = host_virt;
- pr_dbg("host_virt=0x%p\n", mr->user_mr.host_virt);
- mr->user_mr.length = guest_length;
+ mr->virt = host_virt;
+ pr_dbg("host_virt=0x%p\n", mr->virt);
+ mr->length = guest_length;
pr_dbg("length=%zu\n", guest_length);
- mr->user_mr.guest_start = guest_start;
- pr_dbg("guest_start=0x%" PRIx64 "\n", mr->user_mr.guest_start);
+ mr->start = guest_start;
+ pr_dbg("guest_start=0x%" PRIx64 "\n", mr->start);
- length = mr->user_mr.length;
- addr = mr->user_mr.host_virt;
+ length = mr->length;
+ addr = mr->virt;
}
ret = rdma_backend_create_mr(&mr->backend_mr, &pd->backend_pd, addr,
length,
@@ -214,7 +214,7 @@ void rdma_rm_dealloc_mr(RdmaDeviceResources *dev_res,
uint32_t mr_handle)
if (mr) {
rdma_backend_destroy_mr(&mr->backend_mr);
- munmap(mr->user_mr.host_virt, mr->user_mr.length);
+ munmap(mr->virt, mr->length);
res_tbl_dealloc(&dev_res->mr_tbl, mr_handle);
}
}
diff --git a/hw/rdma/rdma_rm_defs.h b/hw/rdma/rdma_rm_defs.h
index 226011176d..7228151239 100644
--- a/hw/rdma/rdma_rm_defs.h
+++ b/hw/rdma/rdma_rm_defs.h
@@ -55,16 +55,12 @@ typedef struct RdmaRmCQ {
bool notify;
} RdmaRmCQ;
-typedef struct RdmaRmUserMR {
- void *host_virt;
- uint64_t guest_start;
- size_t length;
-} RdmaRmUserMR;
-
/* MR (DMA region) */
typedef struct RdmaRmMR {
RdmaBackendMR backend_mr;
- RdmaRmUserMR user_mr;
+ void *virt;
+ uint64_t start;
+ size_t length;
uint32_t pd_handle;
uint32_t lkey;
uint32_t rkey;
--
2.17.1
- [Qemu-devel] [PATCH PULL 00/15] RDMA queue, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 02/15] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 01/15] hw/rdma: Make distinction between device init and start modes, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 03/15] hw/rdma: Modify debug macros, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 04/15] hw/pvrdma: Clean CQE before use, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 05/15] hw/pvrdma: Make default pkey 0xFFFF, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 06/15] hw/rdma: Delete useless structure RdmaRmUserMR,
Marcel Apfelbaum <=
- [Qemu-devel] [PATCH PULL 08/15] hw/rdma: Reorder resource cleanup, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 09/15] hw/pvrdma: Cosmetic change - indent right, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 07/15] hw/rdma: Do not allocate memory for non-dma MR, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 14/15] hw/pvrdma: remove not needed include, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 12/15] hw/rdma: Bugfix - Support non-aligned buffers, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 13/15] hw/rdma: Add reference to pci_dev in backend_dev, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 10/15] hw/rdma: Cosmetic change - move to generic function, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 11/15] hw/rdma: Print backend QP number in hex format, Marcel Apfelbaum, 2018/08/20
- [Qemu-devel] [PATCH PULL 15/15] config: split PVRDMA from RDMA, Marcel Apfelbaum, 2018/08/20
- Re: [Qemu-devel] [PATCH PULL 00/15] RDMA queue, Peter Maydell, 2018/08/20