[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/4] pc-dimm: pre_plug "slot" and "addr" assi
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/4] pc-dimm: pre_plug "slot" and "addr" assignment |
Date: |
Mon, 20 Aug 2018 18:15:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 01.08.2018 15:34, David Hildenbrand wrote:
> This is basically a resend of v3 with commit message changes.
>
> Paolo, if there are no further comments, can you please pick this up for
> 3.1? Thanks!
Paolo,
can you please pick this up? Thanks!
>
> ---
>
> As requested by Igor, assign and verify "slot" and "addr" in the
> pre_plug handler. Factor out the compatibility handling/configuration
> for detecting the alignment to be used when searching for an address
> in guest physical memory for a memory device.
>
> This is another part of the original series
> [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers
>
> This refactoring is the last step before factoring out pre_plug, plug and
> unplug logic of memory devices completely into memory-device.c
>
> v3 -> v4:
> - Added rb/acks
> - Fixed up patch description of last patch
>
> v2 -> v3:
> - "util/oslib-win32: indicate alignment for qemu_anon_ram_alloc()"
> -- take allocation granularity into account
> -- drop comment
> - "pc-dimm: assign and verify the "addr" property during pre_plug"
> -- compat_align -> legacy_align
> -- shortened align detection as proposed by Igor
> -- trace address asignment in pre_plug
>
> v1 -> v2:
> - dropped "machine: factor out enforce_aligned_dimm into memory_device_align"
> - dropped "pc-dimm/memory-device: detect alignment internally"
> - added "util/oslib-win32: indicate alignment for qemu_anon_ram_alloc()"
> -- indicate the alignment and therefor simplify compat handling for
> Windows as we can ...
> - added "pc: drop memory region alignment check for 0"
> -- ... drop a check for memory_region_get_alignment(mr), allowing us to
> factor out compat handling for pc DIMM/NVDIMM alignment in a clean way.
> - "pc-dimm: assign and verify the "addr" property during pre_plug"
> -- Default to "memory_region_get_alignment(mr)" if no compat alignment
> has been specified.
>
> David Hildenbrand (4):
> pc-dimm: assign and verify the "slot" property during pre_plug
> util/oslib-win32: indicate alignment for qemu_anon_ram_alloc()
> pc: drop memory region alignment check for 0
> pc-dimm: assign and verify the "addr" property during pre_plug
>
> hw/i386/pc.c | 16 ++++-------
> hw/mem/pc-dimm.c | 61 +++++++++++++++++++++-------------------
> hw/ppc/spapr.c | 14 ++++++---
> include/hw/mem/pc-dimm.h | 5 ++--
> util/oslib-win32.c | 15 ++++++++--
> 5 files changed, 63 insertions(+), 48 deletions(-)
>
--
Thanks,
David / dhildenb
- [Qemu-devel] [PATCH v4 0/4] pc-dimm: pre_plug "slot" and "addr" assignment, David Hildenbrand, 2018/08/01
- [Qemu-devel] [PATCH v4 1/4] pc-dimm: assign and verify the "slot" property during pre_plug, David Hildenbrand, 2018/08/01
- [Qemu-devel] [PATCH v4 2/4] util/oslib-win32: indicate alignment for qemu_anon_ram_alloc(), David Hildenbrand, 2018/08/01
- [Qemu-devel] [PATCH v4 3/4] pc: drop memory region alignment check for 0, David Hildenbrand, 2018/08/01
- [Qemu-devel] [PATCH v4 4/4] pc-dimm: assign and verify the "addr" property during pre_plug, David Hildenbrand, 2018/08/01
- Re: [Qemu-devel] [PATCH v4 0/4] pc-dimm: pre_plug "slot" and "addr" assignment, Igor Mammedov, 2018/08/02
- Re: [Qemu-devel] [PATCH v4 0/4] pc-dimm: pre_plug "slot" and "addr" assignment,
David Hildenbrand <=