Re: [Qemu-devel] [PATCH 3/5] target/s390x: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128

[Richard Henderson]

On 08/17/2018 10:03 AM, Emilio G. Cota wrote:
>> -        if (((4 << fc) | (1 << sc)) & mask) {
>> +        if ((HAVE_CMPXCHG128 ? 0 : fsize > max) ||
>> +            (HAVE_ATOMIC128  ? 0 : ssize > max)) {
> I don't know what fsize/ssize are, so this is hard to review
> for me--just opened the PoO for the first time ever, and I'm
> even more confused :-)

I've renamed the variables to swap_size and store_size;
hopefully that makes this clearer.


r~