Re: [Qemu-devel] [PULL 08/12] spice-display: fix qemu_spice_cursor_refresh_bh locking

[Paolo Bonzini]

On 21/08/2018 09:45, Gerd Hoffmann wrote:
> +    qemu_mutex_lock(&ssd->lock);
>      if (ssd->cursor) {
> +        QEMUCursor *c = ssd->cursor;
>          assert(ssd->dcl.con);
> +        cursor_get(c);
> +        qemu_mutex_unlock(&ssd->lock);
>          dpy_cursor_define(ssd->dcl.con, ssd->cursor);

Gerd,

this ssd->cursor should be "c" in the call to dpy_cursor_define.  My
apologies; please tell me if you'd like me to send a follow-up fix.

Paolo

> +        qemu_mutex_lock(&ssd->lock);
> +        cursor_put(c);
>      }