[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] hw/nvram/nrf51_nvm: Add nRF51 non-volatile
From: |
Steffen Görtz |
Subject: |
Re: [Qemu-devel] [PATCH 2/7] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories |
Date: |
Tue, 21 Aug 2018 10:31:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
Hi Peter,
>> +
>> +static Property nrf51_nvm_properties[] = {
>> + DEFINE_PROP_UINT16("page_size", Nrf51NVMState, page_size, 0x400),
>
> Do the different NRF51 variants really have different NAND page sizes ?
>
it seems that is not the case at least for the NRF51 Series. I removed the
property in favor for a nrf51.h-wide constant. I think this is NOR flash btw,
because it is single-byte writable, which is usually a sign that it is NOR
flash. But i could be wrong and the datasheet does not state anything.
Thank you for your remarks!
Steffen
- Re: [Qemu-devel] [PATCH 1/7] hw/misc/nrf51_rng: Add NRF51 random number generator peripheral, (continued)
- [Qemu-devel] [PATCH 7/7] hw/display/led_matrix: Add LED matrix display device, Steffen Görtz, 2018/08/06
- [Qemu-devel] [PATCH 5/7] tests/microbit-test: Add Tests for nRF51 GPIO, Steffen Görtz, 2018/08/06
- [Qemu-devel] [PATCH 2/7] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories, Steffen Görtz, 2018/08/06
- [Qemu-devel] [PATCH 4/7] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral, Steffen Görtz, 2018/08/06
- [Qemu-devel] [PATCH 3/7] tests: Add bbc:microbit / nRF51 test suite, Steffen Görtz, 2018/08/06
- [Qemu-devel] [PATCH 6/7] hw/timer/nrf51_timer: Add nRF51 Timer peripheral, Steffen Görtz, 2018/08/06
- Re: [Qemu-devel] [PATCH 0/7] arm: nRF51 Devices and Microbit Support, Peter Maydell, 2018/08/06