[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangl
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list |
Date: |
Thu, 23 Aug 2018 12:33:33 +0200 |
On Thu, 23 Aug 2018 11:25:02 +0100
Daniel P. Berrangé <address@hidden> wrote:
> In some cases the Author: email address in patches submitted to the
> list gets mangled such that it says
>
> John Doe via Qemu-devel <address@hidden>
>
> This change is a result of workarounds for DMARC policies.
>
> Subsystem maintainers accepting patches need to catch these and fix
> them before sending pull requests, so a checkpatch.pl test is highly
> desirable.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
> scripts/checkpatch.pl | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 42e1c50dd8..be2114a179 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1402,6 +1402,10 @@ sub process {
> $is_patch = 1;
> }
>
> + if ($line =~ /^Author: .*via Qemu-devel.*<address@hidden>/) {
> + ERROR("Author email address is mangled by the mailing
> list\n" . $herecurr);
> + }
> +
> #check the patch for a signoff:
> if ($line =~ /^\s*signed-off-by:/i) {
> # This is a signoff, if ugly, so do not double report.
Acked-by: Cornelia Huck <address@hidden>