[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] target/mips: Add MXU register support
From: |
Aleksandar Markovic |
Subject: |
Re: [Qemu-devel] [PATCH 1/7] target/mips: Add MXU register support |
Date: |
Mon, 27 Aug 2018 12:41:39 +0000 |
> From: Craig Janeczek <address@hidden>
> Sent: Friday, August 24, 2018 9:44 PM
>
> Subject: [PATCH 1/7] target/mips: Add MXU register support
>
>This commit makes the MXU registers and the helper functions for
> reading/writing to them. This is required for full MXU instruction
> support.
> Signed-off-by: Craig Janeczek <address@hidden>
Also, Craig,
This patch will cause compiler errors if QEMU is built with clang, with this
patch as the last one. Clang will complain about unused functions. This will
affect bisect algorithms. you should move definition of the functions to the
patches where they are used for the first time in the series.
Otherwise, overall, we want the content of your series integrated, you just
need to improve/correct the code.
Regards,
Aleksandar
- [Qemu-devel] [PATCH 0/7] Add limited MXU instruction support, Craig Janeczek, 2018/08/24
- [Qemu-devel] [PATCH 6/7] target/mips: Add MXU instructions Q8MUL and Q8MULSU, Craig Janeczek, 2018/08/24
- [Qemu-devel] [PATCH 2/7] target/mips: Add MXU instructions S32I2M and S32M2I, Craig Janeczek, 2018/08/24
- [Qemu-devel] [PATCH 1/7] target/mips: Add MXU register support, Craig Janeczek, 2018/08/24
- [Qemu-devel] [PATCH 4/7] target/mips: Add MXU instruction D16MUL, Craig Janeczek, 2018/08/24
- [Qemu-devel] [PATCH 3/7] target/mips: Add MXU instruction S8LDD, Craig Janeczek, 2018/08/24
- [Qemu-devel] [PATCH 7/7] target/mips: Add MXU instructions S32LDD and S32LDDR, Craig Janeczek, 2018/08/24
- [Qemu-devel] [PATCH 5/7] target/mips: Add MXU instruction D16MAC, Craig Janeczek, 2018/08/24