|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PULL 21/52] hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module |
| Date: | Sun, 9 Sep 2018 22:34:38 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 24/08/2018 11:33, Peter Maydell wrote:
> ze);
> +
> + if (offset >= A_TIMERITCR) {
> + switch (offset) {
> + case A_TIMERITCR:
> + s->timeritcr = value & R_TIMERITCR_VALID_MASK;
> + cmsdk_apb_dualtimer_update(s);
> + case A_TIMERITOP:
> + s->timeritop = value & R_TIMERITOP_VALID_MASK;
> + cmsdk_apb_dualtimer_update(s);
> + default:
Two missing "break"s here (Coverity CID 1395626 and 1395633).
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |