[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] qsp: drop atomics when using the seqlock
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] qsp: drop atomics when using the seqlock |
Date: |
Mon, 10 Sep 2018 01:32:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 03/09/2018 19:18, Emilio G. Cota wrote:
> Using atomics here is a mistake since they're not guaranteed
> to compile.
But isn't it technically a C11 data race if you don't use atomics?
Could we make nocheck read/set degrade to just a volatile access when
used on a variable that is bigger than pointers, or perhaps always
except when using tsan?
Paolo
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> util/qsp.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
- Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode, (continued)
[Qemu-devel] [PATCH 2/6] test-rcu-list: avoid torn accesses to n_reclaims and n_nodes_removed, Emilio G. Cota, 2018/09/03
[Qemu-devel] [PATCH 1/6] qsp: drop atomics when using the seqlock, Emilio G. Cota, 2018/09/03
- Re: [Qemu-devel] [PATCH 1/6] qsp: drop atomics when using the seqlock,
Paolo Bonzini <=
Re: [Qemu-devel] [PATCH 0/6] i386 + x86_64 mttcg, Paolo Bonzini, 2018/09/11