[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reo
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen |
Date: |
Thu, 13 Sep 2018 15:32:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 06.09.18 11:37, Alberto Garcia wrote:
> 'discard' is one of the basic BlockdevOptions available for all
> drivers, but it's not handled by bdrv_reopen_prepare() so any attempt
> to change it results in an error:
>
> (qemu) qemu-io virtio0 "reopen -o discard=on"
> Cannot change the option 'discard'
>
> Since there's no reason why we shouldn't allow changing it and the
> implementation is simple let's just do it.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> block.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 00/10] Misc reopen-related patches, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 04/10] block: Don't look for child references in append_open_options(), Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 02/10] file-posix: x-check-cache-dropped should default to false on reopen, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 07/10] file-posix: Forbid trying to change unsupported options during reopen, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 03/10] block: Remove child references from bs->{options, explicit_options}, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 06/10] block: Forbid trying to change unsupported options during reopen, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 10/10] block: Allow changing 'force-share' on reopen, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 05/10] block: Allow child references on reopen, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 09/10] block: Allow changing 'detect-zeroes' on reopen, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 01/10] qemu-io: Fix writethrough check in reopen, Alberto Garcia, 2018/09/06