Re: [Qemu-devel] [PATCH] file-posix: Include filename in locking error message

[Eric Blake]

On 9/25/18 12:05 AM, Fam Zheng wrote:
> Image locking errors happening at device initialization time doesn't say
> which file cannot be locked, for instance,
>
>      -device scsi-disk,drive=drive-1: Failed to get shared "write" lock
>      Is another process using the image?
>
> could refer to either the overlay image or its backing image.
>
> Hoist the error_append_hint to the caller of raw_check_lock_bytes where
> file name is known, and include it in the error hint.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---

Nice improvement.
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org