[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RFC v4 4/7] qemu_thread_join: fix segmentation fault
From: |
Fei Li |
Subject: |
[Qemu-devel] [PATCH RFC v4 4/7] qemu_thread_join: fix segmentation fault |
Date: |
Wed, 26 Sep 2018 18:02:43 +0800 |
To avoid the segmentation fault in qemu_thread_join(), just directly
return when the QemuThread *thread failed to be created in either
qemu-thread-posix.c or qemu-thread-win32.c.
Signed-off-by: Fei Li <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
---
util/qemu-thread-posix.c | 3 +++
util/qemu-thread-win32.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c
index dfa66ff2fb..289af4fab5 100644
--- a/util/qemu-thread-posix.c
+++ b/util/qemu-thread-posix.c
@@ -562,6 +562,9 @@ void *qemu_thread_join(QemuThread *thread)
int err;
void *ret;
+ if (!thread->thread) {
+ return NULL;
+ }
err = pthread_join(thread->thread, &ret);
if (err) {
error_exit(err, __func__);
diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c
index 4a363ca675..1a27e1cf6f 100644
--- a/util/qemu-thread-win32.c
+++ b/util/qemu-thread-win32.c
@@ -366,7 +366,7 @@ void *qemu_thread_join(QemuThread *thread)
HANDLE handle;
data = thread->data;
- if (data->mode == QEMU_THREAD_DETACHED) {
+ if (data == NULL || data->mode == QEMU_THREAD_DETACHED) {
return NULL;
}
--
2.13.7
- [Qemu-devel] [PATCH RFC v4 0/7] qemu_thread_create: propagate errors to callers to check, Fei Li, 2018/09/26
- [Qemu-devel] [PATCH RFC v4 2/7] ui/vnc.c: polish vnc_init_func, Fei Li, 2018/09/26
- [Qemu-devel] [PATCH RFC v4 1/7] Fix segmentation fault when qemu_signal_init fails, Fei Li, 2018/09/26
- [Qemu-devel] [PATCH RFC v4 3/7] qemu_init_vcpu: add a new Error parameter to propagate, Fei Li, 2018/09/26
- [Qemu-devel] [PATCH RFC v4 4/7] qemu_thread_join: fix segmentation fault,
Fei Li <=
- [Qemu-devel] [PATCH RFC v4 5/7] migration: fix the multifd code, Fei Li, 2018/09/26
- [Qemu-devel] [PATCH RFC v4 6/7] migration: fix error handling, Fei Li, 2018/09/26
- [Qemu-devel] [PATCH RFC v4 7/7] qemu_thread_create: propagate the error to callers to handle, Fei Li, 2018/09/26