[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 8/9] qcow2: Set the default cache-clean-inte
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v12 8/9] qcow2: Set the default cache-clean-interval to 10 minutes |
Date: |
Fri, 28 Sep 2018 12:49:09 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 28.09.2018 um 05:59 hat Leonid Bloch geschrieben:
>
>
> On September 27, 2018 5:53:34 PM CEST, Eric Blake <address@hidden> wrote:
> >On 9/26/18 11:04 AM, Leonid Bloch wrote:
> >> The default cache-clean-interval is set to 10 minutes, in order to
> >lower
> >> the overhead of the qcow2 caches (before the default was 0, i.e.
> >> disabled).
> >>
> >> * For non-Linux platforms the default is kept at 0, because
> >> cache-clean-interval is not supported there yet.
> >>
> >> Signed-off-by: Leonid Bloch <address@hidden>
> >> Reviewed-by: Alberto Garcia <address@hidden>
> >> Reviewed-by: Kevin Wolf <address@hidden>
> >> ---
> >
> >> @@ -76,13 +76,15 @@
> >>
> >> #ifdef CONFIG_LINUX
> >> #define DEFAULT_L2_CACHE_MAX_SIZE S_32MiB
> >> +#define DEFAULT_CACHE_CLEAN_INTERVAL 600 /* seconds */
> >> #else
> >> #define DEFAULT_L2_CACHE_MAX_SIZE S_8MiB
> >> +/* Cache clean interval is currently available only on Linux, so
> >must be 0 */
> >> +#define DEFAULT_CACHE_CLEAN_INTERVAL 0
> >> #endif
> >>
> >
> >> +++ b/docs/qcow2-cache.txt
> >> @@ -210,8 +210,8 @@ This example removes all unused cache entries
> >every 15 minutes:
> >>
> >> -drive file=hd.qcow2,cache-clean-interval=900
> >>
> >> -If unset, the default value for this parameter is 0 and it disables
> >> -this feature.
> >> +If unset, the default value for this parameter is 600. Setting it to
> >0
> >> +disables this feature.
> >
> >Should this wording mention that the non-zero default is only on Linux
> >(or rather, only on platforms where a non-zero value makes a
> >difference)?
>
> Yes, I think it should mention it, thanks. Should I send a separate patch?
Yes, please use a follow-up patch if you want to improve the
documentation.
Kevin
- [Qemu-devel] [PATCH v12 2/9] include: Add a lookup table of sizes, (continued)
- [Qemu-devel] [PATCH v12 2/9] include: Add a lookup table of sizes, Leonid Bloch, 2018/09/26
- [Qemu-devel] [PATCH v12 4/9] qcow2: Avoid duplication in setting the refcount cache size, Leonid Bloch, 2018/09/26
- [Qemu-devel] [PATCH v12 6/9] qcow2: Increase the default upper limit on the L2 cache size, Leonid Bloch, 2018/09/26
- [Qemu-devel] [PATCH v12 3/9] qcow2: Make sizes more humanly readable, Leonid Bloch, 2018/09/26
- [Qemu-devel] [PATCH v12 7/9] qcow2: Resize the cache upon image resizing, Leonid Bloch, 2018/09/26
- [Qemu-devel] [PATCH v12 5/9] qcow2: Assign the L2 cache relatively to the image size, Leonid Bloch, 2018/09/26
- [Qemu-devel] [PATCH v12 9/9] qcow2: Explicit number replaced by a constant, Leonid Bloch, 2018/09/26
- [Qemu-devel] [PATCH v12 8/9] qcow2: Set the default cache-clean-interval to 10 minutes, Leonid Bloch, 2018/09/26
- Re: [Qemu-devel] [PATCH v12 0/9] Take the image size into account when allocating the L2 cache, Kevin Wolf, 2018/09/27