[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/24] qemu-ga patch queue for soft-freeze
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PULL 00/24] qemu-ga patch queue for soft-freeze |
Date: |
Wed, 31 Oct 2018 08:59:56 -0500 |
User-agent: |
alot/0.7 |
Quoting Peter Maydell (2018-10-31 08:23:40)
> On 30 October 2018 at 20:57, Michael Roth <address@hidden> wrote:
> > Sorry for the breakage. Static is indeed useful for qemu-ga, but libudev
> > isn't a hard dependency for qemu-ga so we can get away with simply
> > disabling libudev for static builds. Would the following (squashed into
> > patch 04/24) be acceptable? This fixes static qemu-ga builds for me for
> > both Ubuntu 18.04 and FC27. I'll go ahead submit a v2 shortly since it
> > may be late for you:
> >
> > --- a/configure
> > +++ b/configure
> > @@ -5608,7 +5608,7 @@ fi
> > ##########################################
> > # Do we have libudev
> > if test "$libudev" != "no" ; then
> > - if $pkg_config libudev; then
> > + if $pkg_config libudev && test "$static" != "yes"; then
> > if test "$static" != "yes"; then
>
> Now you've ruled out 'static' in the outer if, this
> inner if can never be false...
Argh, sorry, I'd meant to remove the inner test when I squashed it in. v3
incoming...
>
> > libudev="yes"
> > libudev_libs=$($pkg_config --libs libudev)
>
> thanks
> -- PMM
>
- [Qemu-devel] [PULL 24/24] qga-win: changing --retry-path option behavior, (continued)
- [Qemu-devel] [PULL 24/24] qga-win: changing --retry-path option behavior, Michael Roth, 2018/10/30
- [Qemu-devel] [PULL 03/24] qga: ignore non present cpus when handling qmp_guest_get_vcpus(), Michael Roth, 2018/10/30
- [Qemu-devel] [PULL 04/24] configure: add test for libudev, Michael Roth, 2018/10/30
- [Qemu-devel] [PULL 05/24] qga: linux: report disk serial number, Michael Roth, 2018/10/30
- [Qemu-devel] [PULL 07/24] qga-win: prevent crash when executing fsinfo command, Michael Roth, 2018/10/30
- [Qemu-devel] [PULL 06/24] qga: linux: return disk device in guest-get-fsinfo, Michael Roth, 2018/10/30
- [Qemu-devel] [PULL 08/24] qga-win: fsinfo: pci-info: allow partial info, Michael Roth, 2018/10/30
- Re: [Qemu-devel] [PULL 00/24] qemu-ga patch queue for soft-freeze, Peter Maydell, 2018/10/30
- Re: [Qemu-devel] [PULL 00/24] qemu-ga patch queue for soft-freeze, no-reply, 2018/10/31