|
| From: | Steffen Görtz |
| Subject: | Re: [Qemu-devel] [PATCH v3 08/13] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral |
| Date: | Fri, 2 Nov 2018 12:30:21 -0400 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
Hi Peter,
>
>
>> +static void reflect_dir_bit_in_cnf(NRF51GPIOState *s)
>> +{
>> + uint32_t value = s->dir;
>> + for (size_t i = 0; i < NRF51_GPIO_PINS; i++) {
>
> Similarly here, and I think I saw another use somewhere else
> in this patchset too.
I have removed the c99 style declarations from the gpio device and also from
the tests in microbit-tests.
Thank you for your review!
Steffen
| [Prev in Thread] | Current Thread | [Next in Thread] |