[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 12/16] hw/arm/virt-acpi-build: Add PC-DIMM in S
From: |
Auger Eric |
Subject: |
Re: [Qemu-devel] [RFC v4 12/16] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT |
Date: |
Mon, 5 Nov 2018 14:27:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
Hi Igor,
On 10/22/18 3:40 PM, Igor Mammedov wrote:
> On Thu, 18 Oct 2018 16:30:38 +0200
> Eric Auger <address@hidden> wrote:
>
>> From: Shameer Kolothum <address@hidden>
>>
>> Generate Memory Affinity Structures for PC-DIMM ranges.
>>
>> Signed-off-by: Shameer Kolothum <address@hidden>
>> Signed-off-by: Eric Auger <address@hidden>
>>
>> ---
>> v3 -> v4:
>> - do not use vms->bootinfo.device_memory_start/device_memory_size anymore
>>
>> v1 -> v2:
>> - build_srat_hotpluggable_memory movedc to aml-build
>> ---
>> hw/arm/virt-acpi-build.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
>> index 5785fb697c..8818bbf5ec 100644
>> --- a/hw/arm/virt-acpi-build.c
>> +++ b/hw/arm/virt-acpi-build.c
>> @@ -545,6 +545,7 @@ build_srat(GArray *table_data, BIOSLinker *linker,
>> VirtMachineState *vms)
>> int i, srat_start;
>> uint64_t mem_base;
>> MachineClass *mc = MACHINE_GET_CLASS(vms);
>> + MachineState *ms = MACHINE(vms);
>> const CPUArchIdList *cpu_list = mc->possible_cpu_arch_ids(MACHINE(vms));
>>
>> srat_start = table_data->len;
>> @@ -570,6 +571,9 @@ build_srat(GArray *table_data, BIOSLinker *linker,
>> VirtMachineState *vms)
>> }
>> }
>>
>> + build_srat_hotpluggable_memory(table_data, ms->device_memory->base,
>> + ms->device_memory->mr.size, 0);
> on x86, we use the last node here to make windows happy. I'd use the same
> value here.
OK thank you for the information.
Regards
Eric
>
>> +
>> build_header(linker, table_data, (void *)(table_data->data +
>> srat_start),
>> "SRAT", table_data->len - srat_start, 3, NULL, NULL);
>> }
>
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [RFC v4 12/16] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT,
Auger Eric <=