[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/5] hw/arm/exynos4210: Zero memory allocated for Exy
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 3/5] hw/arm/exynos4210: Zero memory allocated for Exynos4210State |
Date: |
Tue, 6 Nov 2018 11:38:24 +0000 |
In exynos4210_init() we allocate memory for an Exynos4210State
struct. Generally devices can assume that the memory allocated
for their state struct is zero-initialized; we broke that
assumption here by using g_new(). Use g_new0() instead.
(In particular, some code assumes that the various irq arrays
in the Exynos4210Irq sub-struct are zero-initialized.)
In the longer term, this code should be QOMified, and then
the struct memory will be allocated elsewhere and by functions
which always zero-initalize it; but for 3.1 this is a
simple fix.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
---
hw/arm/exynos4210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c
index 827318a0036..af82e955421 100644
--- a/hw/arm/exynos4210.c
+++ b/hw/arm/exynos4210.c
@@ -162,7 +162,7 @@ static uint64_t exynos4210_calc_affinity(int cpu)
Exynos4210State *exynos4210_init(MemoryRegion *system_mem)
{
- Exynos4210State *s = g_new(Exynos4210State, 1);
+ Exynos4210State *s = g_new0(Exynos4210State, 1);
qemu_irq gate_irq[EXYNOS4210_NCPUS][EXYNOS4210_IRQ_GATE_NINPUTS];
SysBusDevice *busdev;
DeviceState *dev;
--
2.19.1
- [Qemu-devel] [PULL 0/5] target-arm queue, Peter Maydell, 2018/11/06
- [Qemu-devel] [PULL 2/5] milkymist: Check for failure trying to load BIOS image, Peter Maydell, 2018/11/06
- [Qemu-devel] [PULL 4/5] target/arm: Set S and PTW in 64-bit PAR format, Peter Maydell, 2018/11/06
- [Qemu-devel] [PULL 1/5] target/arm: Remove can't-happen if() from handle_vec_simd_shli(), Peter Maydell, 2018/11/06
- [Qemu-devel] [PULL 5/5] target/arm: Fix ATS1Hx instructions, Peter Maydell, 2018/11/06
- [Qemu-devel] [PULL 3/5] hw/arm/exynos4210: Zero memory allocated for Exynos4210State,
Peter Maydell <=
- Re: [Qemu-devel] [PULL 0/5] target-arm queue, Peter Maydell, 2018/11/06