[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v15 00/10] Add ARMv8 RAS virtualization support
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v15 00/10] Add ARMv8 RAS virtualization support in QEMU |
Date: |
Thu, 8 Nov 2018 14:25:14 -0800 (PST) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v15 00/10] Add ARMv8 RAS virtualization support in
QEMU
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ea6f559ebb target-arm: kvm64: handle SIGBUS signal from kernel or KVM
f7559fdd5e hw/arm/virt: Add RAS platform version for migration
5d5ce7694f target-arm: kvm64: inject synchronous External Abort
5d4a5f1e8e KVM: Move related hwpoison page functions to accel/kvm/ folder
cfe8041c05 docs: APEI GHES generation and CPER record description
9cbe3a1625 ACPI: Add APEI GHES table generation and CPER record support
f50bae0c92 acpi: add build_append_ghes_generic_status() helper for Generic
Error Status Block
5202c7810c acpi: add build_append_ghes_generic_data() helper for Generic Error
Data Entry
d56660774b acpi: add build_append_ghes_notify() helper for Hardware Error
Notification
f62584522a ACPI: add some GHES structures and macros definition
=== OUTPUT BEGIN ===
Checking PATCH 1/10: ACPI: add some GHES structures and macros definition...
Checking PATCH 2/10: acpi: add build_append_ghes_notify() helper for Hardware
Error Notification...
Checking PATCH 3/10: acpi: add build_append_ghes_generic_data() helper for
Generic Error Data Entry...
Checking PATCH 4/10: acpi: add build_append_ghes_generic_status() helper for
Generic Error Status Block...
Checking PATCH 5/10: ACPI: Add APEI GHES table generation and CPER record
support...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#46:
new file mode 100644
WARNING: line over 80 characters
#106: FILE: hw/acpi/acpi_ghes.c:56:
+ build_append_int_noprefix((void *)hardware_errors, 1,
GHES_ADDRESS_SIZE);
WARNING: line over 80 characters
#134: FILE: hw/acpi/acpi_ghes.c:84:
+ build_append_int_noprefix(table_data, cpu_to_le16(i), 2); /* source id
*/
WARNING: line over 80 characters
#135: FILE: hw/acpi/acpi_ghes.c:85:
+ build_append_int_noprefix(table_data, 0xffff, 2); /* related source id
*/
WARNING: line over 80 characters
#148: FILE: hw/acpi/acpi_ghes.c:98:
+ build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0, 4 /* QWord
access */, 0);
WARNING: line over 80 characters
#172: FILE: hw/acpi/acpi_ghes.c:122:
+ build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0, 4 /* QWord
access */, 0);
ERROR: line over 90 characters
#309: FILE: include/hw/acpi/acpi_ghes.h:29:
+/* The size of Address field in Generic Address Structure, ACPI 2.0/3.0:
5.2.3.1 Generic Address
total: 1 errors, 6 warnings, 311 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/10: docs: APEI GHES generation and CPER record description...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
total: 0 errors, 1 warnings, 97 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/10: KVM: Move related hwpoison page functions to accel/kvm/
folder...
Checking PATCH 8/10: target-arm: kvm64: inject synchronous External Abort...
Checking PATCH 9/10: hw/arm/virt: Add RAS platform version for migration...
Checking PATCH 10/10: target-arm: kvm64: handle SIGBUS signal from kernel or
KVM...
WARNING: line over 80 characters
#80: FILE: hw/acpi/acpi_ghes.c:68:
+ current_block_length = sizeof(AcpiGenericErrorStatus) +
le32_to_cpu(data_length);
WARNING: line over 80 characters
#89: FILE: hw/acpi/acpi_ghes.c:77:
+ if ((data_length + sizeof(AcpiGenericErrorStatus)) >
GHES_MAX_RAW_DATA_LENGTH) {
WARNING: line over 80 characters
#94: FILE: hw/acpi/acpi_ghes.c:82:
+ build_append_ghes_generic_status(block,
cpu_to_le32(ACPI_GEBS_UNCORRECTABLE), 0, 0,
WARNING: line over 80 characters
#106: FILE: hw/acpi/acpi_ghes.c:94:
+ cpu_to_le32(ACPI_CPER_SEV_RECOVERABLE),
cpu_to_le32(0x300), 0, 0,
WARNING: line over 80 characters
#107: FILE: hw/acpi/acpi_ghes.c:95:
+ cpu_to_le32(80)/* the total size of Memory Error Record
*/, fru_id,
total: 0 errors, 5 warnings, 256 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v15 05/10] ACPI: Add APEI GHES table generation and CPER record support, (continued)
- [Qemu-devel] [PATCH v15 05/10] ACPI: Add APEI GHES table generation and CPER record support, Dongjiu Geng, 2018/11/08
- [Qemu-devel] [PATCH v15 07/10] KVM: Move related hwpoison page functions to accel/kvm/ folder, Dongjiu Geng, 2018/11/08
- [Qemu-devel] [PATCH v15 10/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM, Dongjiu Geng, 2018/11/08
- [Qemu-devel] [PATCH v15 08/10] target-arm: kvm64: inject synchronous External Abort, Dongjiu Geng, 2018/11/08
- [Qemu-devel] [PATCH v15 03/10] acpi: add build_append_ghes_generic_data() helper for Generic Error Data Entry, Dongjiu Geng, 2018/11/08
- [Qemu-devel] [PATCH v15 06/10] docs: APEI GHES generation and CPER record description, Dongjiu Geng, 2018/11/08
- [Qemu-devel] [PATCH v15 09/10] hw/arm/virt: Add RAS platform version for migration, Dongjiu Geng, 2018/11/08
- [Qemu-devel] [PATCH v15 01/10] ACPI: add some GHES structures and macros definition, Dongjiu Geng, 2018/11/08
- [Qemu-devel] [PATCH v15 02/10] acpi: add build_append_ghes_notify() helper for Hardware Error Notification, Dongjiu Geng, 2018/11/08
- [Qemu-devel] [PATCH v15 04/10] acpi: add build_append_ghes_generic_status() helper for Generic Error Status Block, Dongjiu Geng, 2018/11/08
- Re: [Qemu-devel] [PATCH v15 00/10] Add ARMv8 RAS virtualization support in QEMU,
no-reply <=
- Re: [Qemu-devel] [PATCH v15 00/10] Add ARMv8 RAS virtualization support in QEMU, no-reply, 2018/11/08