[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] keymaps: detect recursive keyboard layout file
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] keymaps: detect recursive keyboard layout file |
Date: |
Thu, 15 Nov 2018 11:15:13 +0100 |
User-agent: |
NeoMutt/20180716 |
On Thu, Nov 15, 2018 at 01:04:23AM -0800, Li Qiang wrote:
> When the parse_keyboard_layout() find a "include " line
> in the keyboard layout file, it will call parse_keyboard_layout()
> to perform a recursive parse. If the keyboard layout is malformed
> by adding a line include itself, this can cause an infinite parse.
> Thus cause qemu a segv. This patch avoid this.
Hmm. Most keymap files are generated by qemu-keymap these days and do
not use includes in the first place. Three are left over: nl-be, sl,
sv.
Looking at them it seems like nl-be is not functional, it just includes
"common" and doesn't define any mappings. For sl and sv I have no clue
what keymap they represent.
So I'd suggest to just remove support for "include", drop the nl-be map,
fix the sl and sv maps that they don't need "include" any more. Either
just replace the "include" statement with the content of the "common"
file. Or, if someone has a clue what keyboard layout these keymaps are
for, add rules to the Makefile and update them using then using
qemu-keymap.
cheers,
Gerd