|
From: | Wainer dos Santos Moschetta |
Subject: | Re: [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed |
Date: | Wed, 21 Nov 2018 10:06:45 -0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 11/20/2018 08:52 PM, Eric Blake wrote:
The use of TLS while building qemu is optional. While the 'certtool' binary should be available on every platform that supports building against TLS, that does not imply that the developer has installed it. Make the test gracefully skip in that case. Reported-by: Kevin Wolf <address@hidden> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Wainer dos Santos Moschetta <address@hidden>
--- On Fedora, libvirt requires libtls-utils to be present, but not qemu. I'm fine if Kevin wants to pick this up in a pull request related to iotests in general; if not, I'll do a pull request through my NBD tree in time for -rc3. tests/qemu-iotests/common.tls | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/common.tls b/tests/qemu-iotests/common.tls index 39f17c1b999..eae81789bbc 100644 --- a/tests/qemu-iotests/common.tls +++ b/tests/qemu-iotests/common.tls @@ -31,6 +31,9 @@ tls_x509_cleanup() tls_x509_init() { + (certtool --help) >/dev/null 2>&1 || \ + _notrun "certtool utility not found, skipping test" + mkdir -p "${tls_dir}" # use a fixed key so we don't waste system entropy on
[Prev in Thread] | Current Thread | [Next in Thread] |