Re: [Qemu-devel] [PATCH for-3.2 v7 6/6] hw/riscv/virt: Connect a VirtIO net PCIe device

[Logan Gunthorpe]

On 2018-11-21 11:34 a.m., Alistair Francis wrote:
>> I don't understand what this patch actually accomplishes. It doesn't
>> seem to affect my network devices when running QEMU. Can you provide a
>> commit message explaining this?
> 
> Could you connect a PCIe networking device without this commit? This
> is what the other architectures all do as well.

Yes, actually.

Other architectures doing something is never a sufficient justification
to make a change. I'm also not sure how virtio relates to this patch...

I'd say unless you know you're fixing something specific and can
describe it, you should drop this patch.

Logan