[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 21/48] *-user: plugin syscalls
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [RFC 21/48] *-user: plugin syscalls |
Date: |
Fri, 23 Nov 2018 19:03:59 -0500 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Fri, Nov 23, 2018 at 17:04:28 +0000, Alex Bennée wrote:
>
> Emilio G. Cota <address@hidden> writes:
>
> > Signed-off-by: Emilio G. Cota <address@hidden>
> > ---
> > bsd-user/syscall.c | 9 +++++++++
> > linux-user/syscall.c | 3 +++
> > 2 files changed, 12 insertions(+)
> >
> > diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c
> > index b7818af450..4993f81b2b 100644
> > --- a/bsd-user/syscall.c
> > +++ b/bsd-user/syscall.c
> > @@ -323,6 +323,8 @@ abi_long do_freebsd_syscall(void *cpu_env, int num,
> > abi_long arg1,
> > gemu_log("freebsd syscall %d\n", num);
> > #endif
> > trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6,
> > arg7, arg8);
> > + qemu_plugin_vcpu_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6,
> > arg7,
> > + arg8);
>
> I think we discussed this on my series about avoiding this sort of
> duplication by providing a wrapper for trace points that are also plugin
> hooks. So something like:
>
> trace_and_plugin_guest_user_syscall(...)
>
> Although it's probably worth keeping the trace names grep-able so maybe:
>
> plug_trace_guest_user_syscall(...)
>
> ?
Yes, I remember that discussion and agree that a common function here
would be best.
Emilio