Re: [Qemu-devel] [PATCH 2/5] The discard flag for block stream operation

[Eric Blake]

On 11/22/18 12:48 PM, Andrey Shinkevich wrote:
> Adding a parameter to QMP block-stream command to allow discarding
> blocks in the backing chain while blocks are being copied to the
> active layer.
>
> Signed-off-by: Andrey Shinkevich <address@hidden>
> ---
>   block/stream.c            | 3 +--
>   blockdev.c                | 8 +++++++-
>   hmp-commands.hx           | 4 ++--
>   hmp.c                     | 4 +++-
>   include/block/block_int.h | 2 +-
>   qapi/block-core.json      | 5 ++++-
>   6 files changed, 18 insertions(+), 8 deletions(-)

> +++ b/qapi/block-core.json
> @@ -2334,6 +2334,9 @@
>   #
>   # @speed:  the maximum speed, in bytes per second
>   #
> +# @discard: true to delete blocks duplicated in old backing files.
> +#           (default: false). Since 3.1.
> +#

This feels like a feature addition and not a bug fix, so not appropriate 
for 3.1-rc3.  The next release will be 4.0, so the "since" line should 
be updated accordingly.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org