[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.1?] target/arm/sve_helper: Fix compilation
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH for-3.1?] target/arm/sve_helper: Fix compilation with clang 3.4 |
Date: |
Wed, 28 Nov 2018 15:39:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-11-28 15:34, Philippe Mathieu-Daudé wrote:
> On 28/11/18 10:58, Thomas Huth wrote:
>> Clang 3.4 does not know the "flatten" attribute yet. We've already
>> introduced the QEMU_FLATTEN macro for this in commit 97ff87c0ed020c2,
>> so use this macro now here, too, to fix this issue.
>
> checkpatch candidate?
I think we'd rather need a docker-based test with such an old version of
Clang... (since there are also other issues like the double-typedef
problem that regularly occurs there).
Thomas