[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails |
Date: |
Thu, 29 Nov 2018 09:35:11 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Fei Li <address@hidden> writes:
> On 11/28/2018 08:53 PM, Markus Armbruster wrote:
>> Fei Li <address@hidden> writes:
>>
>>> When qemu_signal_init() fails in qemu_init_main_loop(), we return
>>> without setting an error. Its callers crash then when they try to
>>> report the error with error_report_err().
>> Yes, that's a bug. Broken in 2f78e491d7b, v2.2.0. Has escaped notice
>> since qemu_signalfd() is quite unlikely to fail. Could go into 3.1 as a
>> bug fix, but I think punting it to the next release is just fine.
> Thanks. :) BTW, should I send the next version only includes patch 1/5
> and 2/5 separately so that you can merge? (I guess Dave will help to
> merge the other three migration related patches)
I can pick patches out of a series for merging, and I trust Dave can,
too. But keeping unrelated fixes separate is a good idea. I can see
three groups: PATCH 1 (main loop), PATCH 2 (thread abstraction), PATCH
3-5 (migration).
[...]
- [Qemu-devel] [PATCH RFC 0/5] fix some segmentation faults and migration issues, Fei Li, 2018/11/28
- [Qemu-devel] [PATCH RFC 4/5] migration: remove unused &local_err parameter in multifd_save_cleanup, Fei Li, 2018/11/28
- [Qemu-devel] [PATCH RFC 5/5] migration: add more error handling for postcopy_ram_enable_notify, Fei Li, 2018/11/28
- [Qemu-devel] [PATCH RFC 3/5] migration: fix the multifd code when receiving less channels, Fei Li, 2018/11/28
- [Qemu-devel] [PATCH RFC 2/5] qemu_thread_join: fix segmentation fault, Fei Li, 2018/11/28
- [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails, Fei Li, 2018/11/28