Re: [Qemu-devel] [PATCH v11 1/7] bitmap: fix bitmap_count_one

[Wei Wang]

On 12/13/2018 10:28 PM, Dr. David Alan Gilbert wrote:
> * Wei Wang (address@hidden) wrote:
> > BITMAP_LAST_WORD_MASK(nbits) returns 0xffffffff when "nbits=0", which
> > makes bitmap_count_one fail to handle the "nbits=0" case. It appears to be
> > preferred to remain BITMAP_LAST_WORD_MASK identical to the kernel
> > implementation that it is ported from.
> >
> > So this patch fixes bitmap_count_one to handle the nbits=0 case.
> OK; it's a little odd that it's only bitmap_count_one that's being fixed
> for this case; but OK.
>
>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Thanks.

We could also help fix other callers outside this series.
(this one is put here as it helps this optimization feature avoid that 
issue).

Best,
Wei