Re: [Qemu-devel] [PULL 00/32] tcg patch queue

[Richard Henderson]

On 12/16/18 4:43 AM, Peter Maydell wrote:
> On Sun, 16 Dec 2018 at 07:03, Richard Henderson
> <address@hidden> wrote:
>>
>> On 12/15/18 1:18 PM, Peter Maydell wrote:
>>> This didn't pass 'make check' on sparc64 host.
>>> It looks like the handful of tests that exercise TCG
>>> in the process of doing what they do failed, and there
>>> was a tcg assert in there too:
>> ...
>>> qemu-system-x86_64: /home/pm215/qemu/tcg/sparc/tcg-target.inc.c:319:
>>> patch_reloc: Assertion `check_fit_ptr(value, 13)' failed.
>>
>> If there were extra asserts, they should have been outside tcg/foo/*.  Any
>> extra asserts inside I cannot explain.  Unfortunately, sparc and s390 are two
>> that I cannot test directly.
> 
> You have access to the gcc compile farm, right? The sparc
> tests run on gcc202.fsffrance.org.

Ah.  I thought that machine had gone away.

That assertion turns out to be an existing bug.  I'm not sure what within this
patch set triggers it, but my solution in the short term will be to revert
ab20bdc1162.

Would you like me to re-send the pull request with this fixed, or may I address
this in the next patch set?


r~