[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui/cocoa: Include less of the generated modular
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] ui/cocoa: Include less of the generated modular QAPI headers |
|
Date: |
Wed, 19 Dec 2018 23:12:45 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/19/18 10:12 AM, Markus Armbruster wrote:
> Avoids pointless recompilation. Missed in commit 112ed241f5d.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> Untested; I don't have access to a Mac.
You kinda do, open a GitHub account and enable Travis-CI (free for
public projects), then pushing a branch to your GitHub will trigger a
Travis build:
https://travis-ci.org/philmd/qemu/jobs/470146270#L3047
>
> ui/cocoa.m | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index ecf12bfc2e..43e751693c 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -32,7 +32,8 @@
> #include "ui/input.h"
> #include "sysemu/sysemu.h"
> #include "qapi/error.h"
> -#include "qapi/qapi-commands.h"
> +#include "qapi/qapi-commands-block-core.h"
> +#include "qapi/qapi-commands-misc.h"
> #include "sysemu/blockdev.h"
> #include "qemu-version.h"
> #include <Carbon/Carbon.h>
>