[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-4.0 v9 09/16] qemu_thread: supplement error hand
From: |
Fei Li |
Subject: |
[Qemu-devel] [PATCH for-4.0 v9 09/16] qemu_thread: supplement error handling for pci_edu_realize |
Date: |
Tue, 25 Dec 2018 22:04:42 +0800 |
Utilize the existed errp to propagate the error instead of the
temporary &error_abort.
Cc: Markus Armbruster <address@hidden>
Cc: Jiri Slaby <address@hidden>
Signed-off-by: Fei Li <address@hidden>
---
hw/misc/edu.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 3f4ba7ded3..011fe6e0b7 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -356,9 +356,10 @@ static void pci_edu_realize(PCIDevice *pdev, Error **errp)
qemu_mutex_init(&edu->thr_mutex);
qemu_cond_init(&edu->thr_cond);
- /* TODO: let the further caller handle the error instead of abort() here */
- qemu_thread_create(&edu->thread, "edu", edu_fact_thread,
- edu, QEMU_THREAD_JOINABLE, &error_abort);
+ if (!qemu_thread_create(&edu->thread, "edu", edu_fact_thread,
+ edu, QEMU_THREAD_JOINABLE, errp)) {
+ return;
+ }
memory_region_init_io(&edu->mmio, OBJECT(edu), &edu_mmio_ops, edu,
"edu-mmio", 1 * MiB);
--
2.13.7
- [Qemu-devel] [PATCH for-4.0 v9 00/16] qemu_thread_create: propagate the error to callers to handle, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 01/16] Fix segmentation fault when qemu_signal_init fails, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 02/16] migration: fix the multifd code when receiving less channels, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 03/16] migration: remove unused &local_err parameter in multifd_save_cleanup, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 05/16] migration: unify error handling for process_incoming_migration_co, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 04/16] migration: add more error handling for postcopy_ram_enable_notify, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 08/16] qemu_thread: supplement error handling for qmp_dump_guest_memory, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 07/16] qemu_thread: supplement error handling for qemu_X_start_vcpu, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 06/16] qemu_thread: Make qemu_thread_create() handle errors properly, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 09/16] qemu_thread: supplement error handling for pci_edu_realize,
Fei Li <=
- [Qemu-devel] [PATCH for-4.0 v9 10/16] qemu_thread: supplement error handling for h_resize_hpt_prepare, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 11/16] qemu_thread: supplement error handling for emulated_realize, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 12/16] qemu_thread: supplement error handling for iothread_complete/qemu_signalfd_compat, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 14/16] qemu_thread: supplement error handling for vnc_start_worker_thread, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 13/16] qemu_thread: supplement error handling for migration, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 15/16] qemu_thread: supplement error handling for touch_all_pages, Fei Li, 2018/12/25
- [Qemu-devel] [PATCH for-4.0 v9 16/16] qemu_thread_join: fix segmentation fault, Fei Li, 2018/12/25