Re: [Qemu-devel] [PATCH 11/16] typedefs: Remove PS2State

[Thomas Huth]

On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
> PS2State is only used in "hw/input/ps2.h", there is no
> need to expose it via "qemu/typedefs.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  include/hw/input/ps2.h  | 2 ++
>  include/qemu/typedefs.h | 1 -
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/hw/input/ps2.h b/include/hw/input/ps2.h
> index 213aa16aa3..b60455d4f6 100644
> --- a/include/hw/input/ps2.h
> +++ b/include/hw/input/ps2.h
> @@ -31,6 +31,8 @@
>  #define PS2_MOUSE_BUTTON_SIDE   0x08
>  #define PS2_MOUSE_BUTTON_EXTRA  0x10
>  
> +typedef struct PS2State PS2State;
> +
>  /* ps2.c */
>  void *ps2_kbd_init(void (*update_irq)(void *, int), void *update_arg);
>  void *ps2_mouse_init(void (*update_irq)(void *, int), void *update_arg);
> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
> index 927b340bb4..181f8fa68e 100644
> --- a/include/qemu/typedefs.h
> +++ b/include/qemu/typedefs.h
> @@ -82,7 +82,6 @@ typedef struct PixelFormat PixelFormat;
>  typedef struct PostcopyDiscardState PostcopyDiscardState;
>  typedef struct Property Property;
>  typedef struct PropertyInfo PropertyInfo;
> -typedef struct PS2State PS2State;
>  typedef struct QEMUBH QEMUBH;
>  typedef struct QemuConsole QemuConsole;
>  typedef struct QemuDmaBuf QemuDmaBuf;
> 

Reviewed-by: Thomas Huth <address@hidden>