Re: [Qemu-devel] [PATCH] hw/usb: Add generic sys-bus EHCI controller

[Gerd Hoffmann]

On Tue, Jan 08, 2019 at 01:11:29PM +0100, BALATON Zoltan wrote:
> On Tue, 8 Jan 2019, Gerd Hoffmann wrote:
> > On Sat, Dec 29, 2018 at 06:00:57PM +0800, Hongbo Zhang wrote:
> > > This patch introduces a new system bus generic EHCI controller.
> > > For the system bus EHCI controller, we've already had "xlnx",
> > > "exynos4210", "tegra2", "ppc4xx" and "fusbh200", they are specific and
> > > only suitable for their own platforms, platforms such as an Arm server,
> > > may need a generic system bus EHCI controller, this patch creates it,
> > > and the kernel driver ehci_platform.c works well on it.
> > 
> > Added to usb queue.
> 
> Most of these only differ in capsbase and opregbase and we only need a
> separate subclass for them because ehci-sysbus is .abstract=true so cannot
> be instantiated. I wonder if it would be simpler to add properties to
> ehci-sysbus to allow setting these base values and allow it to be used
> directly, then most of these subclasses could be removed and only need
> subclass for those that are really do something more (maybe only fusbh200
> currently).

Not sure it is that simple, I think the class names are also used for
device tree generation ...

cheers,
  Gerd