[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 09/10] qcow2: skip writing zero buffers to e
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v11 09/10] qcow2: skip writing zero buffers to empty COW areas |
Date: |
Tue, 08 Jan 2019 14:40:49 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 18 Dec 2018 08:57:45 AM CET, Anton Nefedov wrote:
> @@ -2126,24 +2202,33 @@ static coroutine_fn int
> qcow2_co_pwritev(BlockDriverState *bs, uint64_t offset,
> goto fail;
> }
>
> + qemu_co_mutex_unlock(&s->lock);
> +
> + ret = handle_alloc_space(bs, l2meta);
> + if (ret < 0) {
> + qemu_co_mutex_lock(&s->lock);
> + goto fail;
> + }
I think you could add a brief comment before the handle_alloc_space()
call to indicate what it does.
The patch looks good to me else, but since it seems you're changing it
in the next revision I'll wait for it.
Berto
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v11 09/10] qcow2: skip writing zero buffers to empty COW areas,
Alberto Garcia <=