Re: [Qemu-devel] [PATCH v3 1/2] globals: Allow global properties to be optional

[Cornelia Huck]

On Thu, 10 Jan 2019 16:04:57 -0200
Eduardo Habkost <address@hidden> wrote:

> Making some global properties optional will let us simplify
> compat code when a given property works on most (but not all)
> subclasses of a given type.
> 
> Device types will be able to opt out from optional compat
> properties by simply not registering those properties.
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes v2 -> v3:
> * Don't ignore all errors, ignore property only if it doesn't
>   exist
> 
> Changes v1 -> v2:
> * (new patch)
> 
> Note: the "An error is fatal for non-hotplugged devices [...]"
> comment that appears in the diff scope is inaccurate, but I will
> fix that in a separate patch because I don't want this to get
> into the way of fixing the crash.
> ---
>  include/hw/qdev-core.h | 3 +++
>  qom/object.c           | 3 +++
>  2 files changed, 6 insertions(+)

Reviewed-by: Cornelia Huck <address@hidden>