|
| From: | Thomas Huth |
| Subject: | Re: [Qemu-devel] [PATCH 06/12] chardev: remove unused 'sioc' variable & cleanup paths |
| Date: | Wed, 16 Jan 2019 06:24:49 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-15 15:52, Daniel P. Berrangé wrote:
> The 'sioc' variable in qmp_chardev_open_socket was unused since
>
> commit 3e7d4d20d3a528b1ed10b1dc3d83119bfb0c5f24
> Author: Peter Xu <address@hidden>
> Date: Tue Mar 6 13:33:17 2018 +0800
>
> chardev: use chardev's gcontext for async connect
[...]
> -error:
> - if (sioc) {
> - object_unref(OBJECT(sioc));
> - }
So who is doing the object_unref() now in case of errors? That commit
did not take care of it ... so it sounds like we could be leaving
references behind in case of errors here?
Thomas
| [Prev in Thread] | Current Thread | [Next in Thread] |