[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/52] arm: disable CONFIG_SERIAL_ISA
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/52] arm: disable CONFIG_SERIAL_ISA |
|
Date: |
Fri, 25 Jan 2019 15:49:13 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-25 11:06, Paolo Bonzini wrote:
> ARM does not have an ISA bus, this device should not be enabled. Kconfig
> catches the contradiction because ARM does not define CONFIG_ISA_BUS.
That description is a little bit wrong, since ARM includes pci.mak, and
pci.mak enables CONFIG_ISA_BUS=y for the IDE code.
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> default-configs/arm-softmmu.mak | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 2420491..3c9351f 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -6,7 +6,6 @@ CONFIG_VGA=y
> CONFIG_NAND=y
> CONFIG_ECC=y
> CONFIG_SERIAL=y
> -CONFIG_SERIAL_ISA=y
> CONFIG_PTIMER=y
> CONFIG_SD=y
> CONFIG_MAX7310=y
Anyway, looking through the code and the description of commit
1401c322c8d431fa750cff8276 I think you're right that CONFIG_SERIAL_ISA
is not required for ARM, so if you change the commit message a little bit:
Reviewed-by: Thomas Huth <address@hidden>