|
| From: | Markus Armbruster |
| Subject: | Re: [Qemu-devel] [PATCH 4/4] wavcapture: Convert to error_report |
| Date: | Thu, 14 Feb 2019 11:01:15 +0100 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> writes:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Kill off a pile of monitor_printf's and cur_mon usage.
You also switch from the two line error format
<error message>
Reason: <strerror(errno)>
to the more common
<error message>: <strerror(errno)>
Suggest to mention that you're changing error messages in the commit
message.
> The only one left in wavcapture.c is the info case.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
| [Prev in Thread] | Current Thread | [Next in Thread] |