Re: [Qemu-devel] [PATCH] vhost-user-test: fix leaks

[Michael S. Tsirkin]

On Wed, Mar 06, 2019 at 07:35:28AM +0100, Thomas Huth wrote:
> On 05/03/2019 23.51, Marc-André Lureau wrote:
> > Spotted by ASAN.
> > 
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > ---
> >  tests/vhost-user-test.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> > index 4cd0a97f13..9364227ba4 100644
> > --- a/tests/vhost-user-test.c
> > +++ b/tests/vhost-user-test.c
> > @@ -588,6 +588,7 @@ static void test_server_free(TestServer *server)
> >          g_test_message("unable to rmdir: path (%s): %s",
> >                         server->tmpfs, strerror(errno));
> >      }
> > +    g_free(server->tmpfs);
> >  
> >      qemu_chr_fe_deinit(&server->chr, true);
> >  
> > @@ -605,6 +606,8 @@ static void test_server_free(TestServer *server)
> >  
> >      g_main_loop_unref(server->loop);
> >      g_main_context_unref(server->context);
> > +    g_cond_clear(&server->data_cond);
> > +    g_mutex_clear(&server->data_mutex);
> >      g_free(server);
> >  }
> 
> Reviewed-by: Thomas Huth <address@hidden>
> 
> ... and queued to my qtest-next branch (unless Michael wants to take it
> through hist vhost tree instead).

No it's fine.

Reviewed-by: Michael S. Tsirkin <address@hidden>