Re: [Qemu-devel] [PATCH v2] exec.c: refactor function flatview_add_to_dispatch()

[Wei Yang]

On Sun, Mar 10, 2019 at 09:54:54PM -0700, address@hidden wrote:
>Patchew URL: https://patchew.org/QEMU/address@hidden/
>
>
>
>Hi,
>
>This series failed the address@hidden build test. Please find the testing 
>commands and
>their output below. If you have Docker installed, you can probably reproduce it
>locally.
>
>=== TEST SCRIPT BEGIN ===
>#!/bin/bash
>time make address@hidden SHOW_ENV=1 J=14 NETWORK=1
>=== TEST SCRIPT END ===
>
>  CC      x86_64-softmmu/accel/tcg/tcg-runtime.o
>  CC      aarch64-softmmu/hw/cpu/realview_mpcore.o
>/tmp/qemu-test/src/exec.c: In function 'flatview_add_to_dispatch':
>/tmp/qemu-test/src/exec.c:1644:32: error: incompatible type for argument 2 of 
>'int128_gt'
>     if (int128_gt(remain.size, 0)) {
>                                ^
>In file included from /tmp/qemu-test/src/include/exec/memory.h:24,
>---
>  CC      aarch64-softmmu/hw/display/vga.o
>  CC      aarch64-softmmu/hw/display/bcm2835_fb.o
>/tmp/qemu-test/src/exec.c: In function 'flatview_add_to_dispatch':
>/tmp/qemu-test/src/exec.c:1644:32: error: incompatible type for argument 2 of 
>'int128_gt'
>     if (int128_gt(remain.size, 0)) {
>                                ^

Not sure why this works at my side.

Fixed this with 

      if (int128_gt(remain.size, int128_make64(0))) {

>In file included from /tmp/qemu-test/src/include/exec/memory.h:24,
>
>
>The full log is available at
>http://patchew.org/logs/address@hidden/address@hidden/?type=message.
>---
>Email generated automatically by Patchew [http://patchew.org/].
>Please send your feedback to address@hidden

-- 
Wei Yang
Help you, Help me