|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH 7/7] coroutine-x86: add CET shadow stack support |
| Date: | Wed, 13 Mar 2019 17:04:49 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 3/13/19 5:40 AM, Paolo Bonzini wrote:
> +static bool have_cet(void)
> +{
> +#if defined CONFIG_CET
> + uint64_t ssp;
> + asm ("xor %0, %0; rdsspq %0\n" : "=rm" (ssp));
The xor is incompatible with a memory output.
I don't think you really wanted that in the first place.
Just use "=r".
The rest is hard to review because of ARCH_X86_CET_ALLOC_SHSTK.
I'm surprised that a prctl actually allocates memory...
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |