[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] scripts/decodetree.py: Fix variable-length
|
From: |
Yoshinori Sato |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH] scripts/decodetree.py: Fix variable-length ISA |
|
Date: |
Fri, 22 Mar 2019 23:16:00 +0900 |
|
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (Gojō) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
On Thu, 21 Mar 2019 10:43:37 +0900,
Richard Henderson wrote:
>
> On 3/20/19 7:27 AM, Yoshinori Sato wrote:
> > Hi.
> > I found some problem in tested RX instructions.
> > It is usable in RX instructions, but I think that there
> > is a better fix because I am not familiar with Python.
>
> The patch itself look ok, but needs some changes.
>
> > I fixed three point.
> > - Added ctx to !function args.
>
> This seems fine. But it needs either
>
> (1) A command-line option, or
> (2) Changes to all existing users in the tree.
>
> Otherwise the build breaks for the other targets.
>
> > - Fixed group operaiton. varinsns required width field.
> > - Fixed symbol in decode_load_bytes args.
>
> Thanks. I can fold these fixes into v2 of the varinsns patches.
>
OK. Thanks.
>
> r~
>
--
Yosinori Sato