[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/7] target/mips: Fix <ld|st>.<b|h|w|d> MSA i
|
From: |
Aleksandar Markovic |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/7] target/mips: Fix <ld|st>.<b|h|w|d> MSA instructions for MIPS big endian host |
|
Date: |
Mon, 25 Mar 2019 21:21:03 +0000 |
> From: Mateja Marjanovic <address@hidden>
> Subject: [PATCH v2 1/7] target/mips: Fix <ld|st>.<b|h|w|d> MSA instructions
> for MIPS big endian host
Please split this patch into one for load instructions and another for
store instructions.
I don't think the variable "big_endian" is needed, you should better resolve
all differences wrt endian via "#if defined(HOST_WORDS_BIGENDIAN)",
like you did in other patches. It is important to be consistent.
Thanks,
Aleksandar
[Qemu-devel] [PATCH v2 3/7] target/mips: Fix copy_u.<b|h|w> for MIPS big endian host, Mateja Marjanovic, 2019/03/25
[Qemu-devel] [PATCH v2 6/7] target/mips: Eliminate unreachable case for MSA instructions insert, Mateja Marjanovic, 2019/03/25
[Qemu-devel] [PATCH v2 7/7] target/mips: Eliminate unreachable case for MSA instructions fill, Mateja Marjanovic, 2019/03/25
Re: [Qemu-devel] [PATCH v2 0/7] target/mips: Add support for MSA instructions on a big endian host, Aleksandar Markovic, 2019/03/25