[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 09/14] vhost: fix memory leak in vhost_user_scsi_r
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v2 09/14] vhost: fix memory leak in vhost_user_scsi_realize |
Date: |
Mon, 3 Jun 2019 14:08:57 -0400 |
From: Jie Wang <address@hidden>
fix memory leak in vhost_user_scsi_realize
Signed-off-by: Jie Wang <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
hw/scsi/vhost-user-scsi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c
index 8b1e6876db..a9fd8ea305 100644
--- a/hw/scsi/vhost-user-scsi.c
+++ b/hw/scsi/vhost-user-scsi.c
@@ -69,6 +69,7 @@ static void vhost_user_scsi_realize(DeviceState *dev, Error
**errp)
VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(dev);
VHostUserSCSI *s = VHOST_USER_SCSI(dev);
VHostSCSICommon *vsc = VHOST_SCSI_COMMON(s);
+ struct vhost_virtqueue *vqs = NULL;
Error *err = NULL;
int ret;
@@ -93,6 +94,7 @@ static void vhost_user_scsi_realize(DeviceState *dev, Error
**errp)
vsc->dev.vqs = g_new(struct vhost_virtqueue, vsc->dev.nvqs);
vsc->dev.vq_index = 0;
vsc->dev.backend_features = 0;
+ vqs = vsc->dev.vqs;
ret = vhost_dev_init(&vsc->dev, &s->vhost_user,
VHOST_BACKEND_TYPE_USER, 0);
@@ -100,6 +102,7 @@ static void vhost_user_scsi_realize(DeviceState *dev, Error
**errp)
error_setg(errp, "vhost-user-scsi: vhost initialization failed: %s",
strerror(-ret));
vhost_user_cleanup(&s->vhost_user);
+ g_free(vqs);
return;
}
--
MST
- [Qemu-devel] [PULL v2 00/14] virtio, pci, pc: cleanups, features, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 01/14] hw/acpi: Consolidate build_mcfg to pci.c, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 02/14] acpi: pci: use build_append_foo() API to construct MCFG, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 03/14] pcie: Simplify pci_adjust_config_limit(), Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 04/14] pci: Make is_bridge a bool, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 05/14] pci: Fold pci_get_bus_devfn() into its sole caller, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 08/14] vhost: fix incorrect print type, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 09/14] vhost: fix memory leak in vhost_user_scsi_realize,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v2 07/14] vhost: remove the dead code, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 06/14] docs: smbios: remove family=x from type2 entry description, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 10/14] bios-tables-test: add diff allowed list, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 11/14] vhost-scsi: The vhost backend should be stopped when the VM is not running, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 12/14] vhost-scsi: Add VMState descriptor, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 13/14] vhost-scsi: Allow user to enable migration, Michael S. Tsirkin, 2019/06/03
- [Qemu-devel] [PULL v2 14/14] bios-tables-test: list all tables that differ, Michael S. Tsirkin, 2019/06/03
- Re: [Qemu-devel] [PULL v2 00/14] virtio, pci, pc: cleanups, features, Peter Maydell, 2019/06/04