Re: [Qemu-devel] [PATCH 2/5] virtio: Migrate the "start_on_kick" flag

[Yongji Xie]

On Tue, 4 Jun 2019 at 04:16, Greg Kurz <address@hidden> wrote:
>
> On Wed, 29 May 2019 15:09:52 +0800
> address@hidden wrote:
>
> > From: Xie Yongji <address@hidden>
> >
> > We should migrate the "start_on_kick" flag so that we
> > would not miss starting device on kicking at startup
> > after migration.
> >
>
> Hmm... IIUC "start_on_kick" means "virtio 1.0 transitional device that has
> not been started yet", ie:
>
> !vdev->started &&
> (virtio_host_has_feature(vdev, VIRTIO_F_VERSION_1) &&
>  !virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1))
>
> If so, not sure why you need this extra field in the first place, but
> you probably don't need to migrate it. Just recalculate in a post load
> callback.
>

Good idea! Will recalculate this in virtio_load() in v2. Thank you.

Thanks,
Yongji