[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 22/27] vl: Create block backends before setting m
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PULL 22/27] vl: Create block backends before setting machine properties |
|
Date: |
Tue, 4 Jun 2019 15:29:02 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 03/06/19 19:40, Markus Armbruster wrote:
>
> Paolo, why is pr-manager-helper a delayed object? Why this hunk of
> commit 7c9e527659c:
>
> diff --git a/vl.c b/vl.c
> index 9bb5058c3a..a121a65731 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2893,7 +2893,8 @@ static int machine_set_property(void *opaque,
> */
> static bool object_create_initial(const char *type)
> {
> - if (g_str_equal(type, "rng-egd")) {
> + if (g_str_equal(type, "rng-egd") ||
> + g_str_has_prefix(type, "pr-manager-")) {
> return false;
> }
>
I don't think there was any particular reason. Change it back to
normal, I can send a pull request today for that.
Paolo