Re: [Qemu-devel] [PATCH v4 00/39] tcg: Move the softmmu tlb to CPUNegativeOffsetState

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v4 00/39] tcg: Move the softmmu tlb to 
CPUNegativeOffsetState
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
63e891f725 tcg/arm: Remove mostly unreachable tlb special case
4f2566a5d2 tcg/arm: Use LDRD to load tlb mask+table
edc357435e tcg/aarch64: Use LDP to load tlb mask+table
712ebadd43 cpu: Remove CPU_COMMON
5aa6a2fb8d cpu: Move the softmmu tlb to CPUNegativeOffsetState
1c40b77322 cpu: Move icount_decr to CPUNegativeOffsetState
1c966d8fcd cpu: Introduce CPUNegativeOffsetState
8468e4bd66 cpu: Introduce cpu_set_cpustate_pointers
ee1b7b6bbd cpu: Move ENV_OFFSET to exec/gen-icount.h
5ff2ffb8b3 target/xtensa: Use env_cpu, env_archcpu
a1c69dbe8f target/unicore32: Use env_cpu, env_archcpu
6a017d55ba target/tricore: Use env_cpu
790da26490 target/tilegx: Use env_cpu
6958fd2246 target/sparc: Use env_cpu, env_archcpu
3dbc8158e8 target/sh4: Use env_cpu, env_archcpu
2d49eb4f00 target/s390x: Use env_cpu, env_archcpu
6dff0c4823 target/riscv: Use env_cpu, env_archcpu
0da4405772 target/ppc: Use env_cpu, env_archcpu
8fdd1e14ff target/openrisc: Use env_cpu, env_archcpu
220d63dba7 target/nios2: Use env_cpu, env_archcpu
1aa560923f target/moxie: Use env_cpu, env_archcpu
1808dbc955 target/mips: Use env_cpu, env_archcpu
3795a4b0f6 target/microblaze: Use env_cpu, env_archcpu
5c889c6702 target/m68k: Use env_cpu, env_archcpu
0bd3d012c8 target/lm32: Use env_cpu, env_archcpu
607ef88980 target/i386: Use env_cpu, env_archcpu
55f5b3354f target/hppa: Use env_cpu, env_archcpu
459c3271ee target/cris: Use env_cpu, env_archcpu
0dea7d8b87 target/cris: Reindent op_helper.c
853bba6046 target/cris: Reindent mmu.c
5854d09536 target/arm: Use env_cpu, env_archcpu
891044bc70 target/alpha: Use env_cpu, env_archcpu
43de9b9faa cpu: Introduce env_archcpu
c67ce1d529 cpu: Replace ENV_GET_CPU with env_cpu
e75b06aefe cpu: Define ArchCPU
c1ee18a202 cpu: Define CPUArchState with typedef
3f2efac55b tcg: Create struct CPUTLB
86ccb48bb0 tcg: Split out target/arch/cpu-param.h
0f46d893fd tcg: Fold CPUTLBWindow into CPUTLBDesc

=== OUTPUT BEGIN ===
1/39 Checking commit 0f46d893fd6f (tcg: Fold CPUTLBWindow into CPUTLBDesc)
2/39 Checking commit 86ccb48bb0f1 (tcg: Split out target/arch/cpu-param.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

total: 0 errors, 1 warnings, 1290 lines checked

Patch 2/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/39 Checking commit 3f2efac55bff (tcg: Create struct CPUTLB)
4/39 Checking commit c1ee18a2024a (cpu: Define CPUArchState with typedef)
5/39 Checking commit e75b06aefefc (cpu: Define ArchCPU)
6/39 Checking commit c67ce1d529df (cpu: Replace ENV_GET_CPU with env_cpu)
7/39 Checking commit 43de9b9faa26 (cpu: Introduce env_archcpu)
8/39 Checking commit 891044bc70d6 (target/alpha: Use env_cpu, env_archcpu)
9/39 Checking commit 5854d09536fd (target/arm: Use env_cpu, env_archcpu)
10/39 Checking commit 853bba604625 (target/cris: Reindent mmu.c)
11/39 Checking commit 0dea7d8b87fd (target/cris: Reindent op_helper.c)
12/39 Checking commit 459c3271eeda (target/cris: Use env_cpu, env_archcpu)
13/39 Checking commit 55f5b3354f8c (target/hppa: Use env_cpu, env_archcpu)
14/39 Checking commit 607ef889808f (target/i386: Use env_cpu, env_archcpu)
15/39 Checking commit 0bd3d012c8e7 (target/lm32: Use env_cpu, env_archcpu)
16/39 Checking commit 5c889c6702ed (target/m68k: Use env_cpu, env_archcpu)
17/39 Checking commit 3795a4b0f698 (target/microblaze: Use env_cpu, env_archcpu)
18/39 Checking commit 1808dbc95514 (target/mips: Use env_cpu, env_archcpu)
19/39 Checking commit 1aa560923f44 (target/moxie: Use env_cpu, env_archcpu)
20/39 Checking commit 220d63dba758 (target/nios2: Use env_cpu, env_archcpu)
21/39 Checking commit 8fdd1e14ff2d (target/openrisc: Use env_cpu, env_archcpu)
22/39 Checking commit 0da440577225 (target/ppc: Use env_cpu, env_archcpu)
23/39 Checking commit 6dff0c4823b7 (target/riscv: Use env_cpu, env_archcpu)
24/39 Checking commit 2d49eb4f0027 (target/s390x: Use env_cpu, env_archcpu)
25/39 Checking commit 3dbc8158e822 (target/sh4: Use env_cpu, env_archcpu)
26/39 Checking commit 6958fd224677 (target/sparc: Use env_cpu, env_archcpu)
27/39 Checking commit 790da264900d (target/tilegx: Use env_cpu)
28/39 Checking commit 6a017d55bae9 (target/tricore: Use env_cpu)
29/39 Checking commit a1c69dbe8f0f (target/unicore32: Use env_cpu, env_archcpu)
30/39 Checking commit 5ff2ffb8b3fc (target/xtensa: Use env_cpu, env_archcpu)
31/39 Checking commit ee1b7b6bbd69 (cpu: Move ENV_OFFSET to exec/gen-icount.h)
32/39 Checking commit 8468e4bd6660 (cpu: Introduce cpu_set_cpustate_pointers)
33/39 Checking commit 1c966d8fcd00 (cpu: Introduce CPUNegativeOffsetState)
34/39 Checking commit 1c40b773225d (cpu: Move icount_decr to 
CPUNegativeOffsetState)
ERROR: return is not a function, parentheses are not required
#193: FILE: cpus.c:242:
+    return (cpu->icount_budget -

total: 1 errors, 0 warnings, 326 lines checked

Patch 34/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

35/39 Checking commit 5aa6a2fb8d0a (cpu: Move the softmmu tlb to 
CPUNegativeOffsetState)
36/39 Checking commit 712ebadd4342 (cpu: Remove CPU_COMMON)
37/39 Checking commit edc357435e8c (tcg/aarch64: Use LDP to load tlb mask+table)
38/39 Checking commit 4f2566a5d206 (tcg/arm: Use LDRD to load tlb mask+table)
39/39 Checking commit 63e891f7255a (tcg/arm: Remove mostly unreachable tlb 
special case)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden